Messages in this thread | | | Subject | Re: [PATCH] phy: usb: Fix incorrect clearing of tca_drv_sel bit in SETUP reg for 7211 | From | Florian Fainelli <> | Date | Fri, 2 Oct 2020 13:21:37 -0700 |
| |
On 10/2/2020 12:01 PM, Al Cooper wrote: > The 7211a0 has a tca_drv_sel bit in the USB SETUP register that > should never be enabled. This feature is only used if there is a > USB Type-C PHY, and the 7211 does not have one. If the bit is > enabled, the VBUS signal will never be asserted. In the 7211a0, > the bit was incorrectly defaulted to on so the driver had to clear > the bit. In the 7211c0 the state was inverted so the driver should > no longer clear the bit. This hasn't been a problem because all > current 7211 boards don't use the VBUS signal, but there are some > future customer boards that may use it. > > Signed-off-by: Al Cooper <alcooperx@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |