lkml.org 
[lkml]   [2020]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 4/4] ftgmac100: Restart MAC HW once
    From
    Date
    On Mon, 2020-10-19 at 16:57 +0800, Dylan Hung wrote:
    > The interrupt handler may set the flag to reset the mac in the
    > future,
    > but that flag is not cleared once the reset has occured.
    >
    > Fixes: 10cbd6407609 ("ftgmac100: Rework NAPI & interrupts handling")
    > Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com>
    > Signed-off-by: Joel Stanley <joel@jms.id.au>

    Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

    > ---
    > drivers/net/ethernet/faraday/ftgmac100.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/net/ethernet/faraday/ftgmac100.c
    > b/drivers/net/ethernet/faraday/ftgmac100.c
    > index 0c67fc3e27df..57736b049de3 100644
    > --- a/drivers/net/ethernet/faraday/ftgmac100.c
    > +++ b/drivers/net/ethernet/faraday/ftgmac100.c
    > @@ -1326,6 +1326,7 @@ static int ftgmac100_poll(struct napi_struct
    > *napi, int budget)
    > */
    > if (unlikely(priv->need_mac_restart)) {
    > ftgmac100_start_hw(priv);
    > + priv->need_mac_restart = false;
    >
    > /* Re-enable "bad" interrupts */
    > ftgmac100_write(FTGMAC100_INT_BAD, priv->base +
    > FTGMAC100_OFFSET_IER);

    \
     
     \ /
      Last update: 2020-10-20 01:27    [W:3.300 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site