lkml.org 
[lkml]   [2020]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 10/23] drm/msm: Use correct drm_gem_object_put() in fail case
    Date
    From: Rob Clark <robdclark@chromium.org>

    We only want to use the _unlocked() variant in the unlocked case.

    Signed-off-by: Rob Clark <robdclark@chromium.org>
    ---
    drivers/gpu/drm/msm/msm_gem.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
    index 6abcf9fe480d..3dcb2ef4740f 100644
    --- a/drivers/gpu/drm/msm/msm_gem.c
    +++ b/drivers/gpu/drm/msm/msm_gem.c
    @@ -1135,7 +1135,11 @@ static struct drm_gem_object *_msm_gem_new(struct drm_device *dev,
    return obj;

    fail:
    - drm_gem_object_put(obj);
    + if (struct_mutex_locked) {
    + drm_gem_object_put_locked(obj);
    + } else {
    + drm_gem_object_put(obj);
    + }
    return ERR_PTR(ret);
    }

    --
    2.26.2
    \
     
     \ /
      Last update: 2020-10-19 22:46    [W:4.102 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site