Messages in this thread | | | Subject | Re: [PATCH] staging: wfx: make a const array static, makes object smaller | From | Christophe JAILLET <> | Date | Mon, 19 Oct 2020 19:52:09 +0200 |
| |
Le 17/10/2020 à 02:11, Joe Perches a écrit : > On Fri, 2020-10-16 at 23:33 +0100, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> Don't populate const array filter_ies on the stack but instead >> make it static. Makes the object code smaller by 261 bytes. >> >> Before: >> text data bss dec hex filename >> 21674 3166 448 25288 62c8 drivers/staging/wfx/sta.o >> >> After: >> text data bss dec hex filename >> 21349 3230 448 25027 61c3 drivers/staging/wfx/sta.o > > Thanks. > > It's odd to me it's so large a change as it's only > 24 bytes of initialization. (3 entries, each 8 bytes) >
The function looks small. Maybe it is inlined by gcc in each of the 3 callers?
CJ
> This line in the same function: > > hif_set_beacon_filter_table(wvif, 3, filter_ies); > > might as well use ARRAY_SIZE(filter_ies) instead of 3 > > >
| |