Messages in this thread Patch in this message | | | Date | Mon, 19 Oct 2020 17:02:46 -0000 | From | "tip-bot2 for Luiz Augusto von Dentz" <> | Subject | [tip: perf/urgent] Bluetooth: MGMT: Fix not checking if BT_HS is enabled |
| |
The following commit has been merged into the perf/urgent branch of tip:
Commit-ID: a0a91211dd0ac6f24393a2917a258de5aeedb842 Gitweb: https://git.kernel.org/tip/a0a91211dd0ac6f24393a2917a258de5aeedb842 Author: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> AuthorDate: Thu, 06 Aug 2020 11:17:14 -07:00 Committer: Greg Kroah-Hartman <gregkh@linuxfoundation.org> CommitterDate: Sat, 17 Oct 2020 08:31:21 +02:00
Bluetooth: MGMT: Fix not checking if BT_HS is enabled
commit b560a208cda0297fef6ff85bbfd58a8f0a52a543 upstream.
This checks if BT_HS is enabled relecting it on MGMT_SETTING_HS instead of always reporting it as supported.
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--- net/bluetooth/mgmt.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index 5bbe710..5758ccb 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -782,7 +782,8 @@ static u32 get_supported_settings(struct hci_dev *hdev) if (lmp_ssp_capable(hdev)) { settings |= MGMT_SETTING_SSP; - settings |= MGMT_SETTING_HS; + if (IS_ENABLED(CONFIG_BT_HS)) + settings |= MGMT_SETTING_HS; } if (lmp_sc_capable(hdev)) @@ -1815,6 +1816,10 @@ static int set_hs(struct sock *sk, struct hci_dev *hdev, void *data, u16 len) bt_dev_dbg(hdev, "sock %p", sk); + if (!IS_ENABLED(CONFIG_BT_HS)) + return mgmt_cmd_status(sk, hdev->id, MGMT_OP_SET_HS, + MGMT_STATUS_NOT_SUPPORTED); + status = mgmt_bredr_support(hdev); if (status) return mgmt_cmd_status(sk, hdev->id, MGMT_OP_SET_HS, status);
| |