lkml.org 
[lkml]   [2020]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] m68k: m68328: remove duplicate code
From
Date
Hi Arnd,

Overall looks good.


On 15/10/20 10:32 pm, Arnd Bergmann wrote:
[snip]
> diff --git a/arch/m68k/Kconfig.cpu b/arch/m68k/Kconfig.cpu
> index 694c4fca9f5d..a65ce7618232 100644
> --- a/arch/m68k/Kconfig.cpu
> +++ b/arch/m68k/Kconfig.cpu
> @@ -35,7 +35,7 @@ endchoice
> if M68KCLASSIC
>
> config M68000
> - bool "MC68000"
> + bool
> depends on !MMU
> select CPU_HAS_NO_BITFIELDS
> select CPU_HAS_NO_MULDIV64
> @@ -102,21 +102,21 @@ config M68060
> processor, say Y. Otherwise, say N.
>
> config M68328
> - bool "MC68328"
> + bool
> depends on !MMU
> select M68000
> help
> Motorola 68328 processor support.
>
> config M68EZ328
> - bool "MC68EZ328"
> + bool
> depends on !MMU
> select M68000
> help
> Motorola 68EX328 processor support.
>
> config M68VZ328
> - bool "MC68VZ328"
> + bool
> depends on !MMU
> select M68000
> help
> diff --git a/arch/m68k/Kconfig.machine b/arch/m68k/Kconfig.machine
> index 17e8c3a292d7..1851c66e8667 100644
> --- a/arch/m68k/Kconfig.machine
> +++ b/arch/m68k/Kconfig.machine
> @@ -136,14 +136,13 @@ config SUN3
>
> If you don't want to compile a kernel exclusively for a Sun 3, say N.
>
> -endif # M68KCLASSIC
> -
> config PILOT
> bool
>
> config PILOT3
> bool "Pilot 1000/5000, PalmPilot Personal/Pro, or PalmIII support"
> - depends on M68328
> + depends on !MMU
> + select M68328

Given that M68328 depends on !MMU do you also need or want that here?

Regards
Greg



\
 
 \ /
  Last update: 2020-10-19 01:46    [W:2.300 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site