Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH] task_work: cleanup notification modes | Date | Sat, 17 Oct 2020 01:09:46 +0200 |
| |
On Fri, Oct 16 2020 at 16:39, Jens Axboe wrote: > On 10/16/20 3:44 PM, Thomas Gleixner wrote: >>> - * @notify: send the notification if true >>> + * @notify: send chosen notification, if any >> >> Is that really all you found to be wrong in that comment? > > There really is nothing wrong, but it's not very descriptive (wasn't > before either).
* This is like the signal handler which runs in kernel mode, but it doesn't * try to wake up the @task.
If find a lot of wrongs in that sentence in context of TWA_SIGNAL.
Agreed, it was hard to understand before that, but with TWA_SIGNAL it does not make sense at all.
Thanks,
tglx
| |