lkml.org 
[lkml]   [2020]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 2/3] clk: qcom: lpass-sc7180: Disentangle the two clock devices
    From
    Date
    Quoting Douglas Anderson (2020-10-14 14:05:22)
    > diff --git a/drivers/clk/qcom/lpasscorecc-sc7180.c b/drivers/clk/qcom/lpasscorecc-sc7180.c
    > index abcf36006926..48d370e2108e 100644
    > --- a/drivers/clk/qcom/lpasscorecc-sc7180.c
    > +++ b/drivers/clk/qcom/lpasscorecc-sc7180.c
    > @@ -356,12 +356,48 @@ static const struct qcom_cc_desc lpass_audio_hm_sc7180_desc = {
    > .num_gdscs = ARRAY_SIZE(lpass_audio_hm_sc7180_gdscs),
    > };
    >
    > +static void lpass_pm_runtime_disable(void *data)
    > +{
    > + pm_runtime_disable(data);
    > +}
    > +
    > +static void lapss_pm_clk_destroy(void *data)
    > +{
    > + pm_clk_destroy(data);
    > +}

    Why are these helpers added again? And do we even need them? Can't we
    just pass pm_runtime_disable or pm_clk_destroy to the
    devm_add_action_or_reset() second parameter?

    \
     
     \ /
      Last update: 2020-10-15 00:11    [W:2.289 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site