Messages in this thread | | | Date | Wed, 14 Oct 2020 19:47:50 +0300 | From | Vladimir Oltean <> | Subject | Re: [PATCH net] net: dsa: ksz: fix padding size of skb |
| |
On Wed, Oct 14, 2020 at 06:17:19PM +0200, Christian Eggers wrote: > __skb_put_padto() is called in order to ensure a minimal size of the > sk_buff. The required minimal size is ETH_ZLEN + the size required for > the tail tag. > > The current argument misses the size for the tail tag. The expression > "skb->len + padlen" can be simplified to ETH_ZLEN. > > Too small sk_buffs typically result from cloning in > dsa_skb_tx_timestamp(). The cloned sk_buff may not meet the minimum size > requirements. > > Fixes: e71cb9e00922 ("net: dsa: ksz: fix skb freeing") > Signed-off-by: Christian Eggers <ceggers@arri.de> > ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
| |