Messages in this thread | | | Subject | Re: [RFC PATCH v2] checkpatch: add shebang check to EXECUTE_PERMISSIONS | From | Joe Perches <> | Date | Wed, 14 Oct 2020 00:35:32 -0700 |
| |
On Wed, 2020-10-14 at 09:17 +0200, Lukas Bulwahn wrote: > $ clang-format-10 --version > Ubuntu clang-format version > 10.0.1-++20200928083909+ef32c611aa2-1~exp1~20200928185400.194 > > $ clang-format-10 --help | grep 'dry-run' > --dry-run - If set, do not actually make the formatting > changes > --ferror-limit=<uint> - Set the maximum number of clang-format > errors to emit before stopping (0 = no limit). Used only with --dry-run or -n > -n - Alias for --dry-run
OK, maybe so.
However I think the clang-format --dry-run output doesn't currently contain particularly useful information. Maybe later versions are better than version 10.
For instance:
$ /usr/bin/clang-format-10 --version clang-format version 10.0.0-4ubuntu1
$ /usr/bin/clang-format-10 --dry-run drivers/net/ethernet/intel/igb/igb_main.c 2>&1 | head -25 drivers/net/ethernet/intel/igb/igb_main.c:54:40: warning: code should be clang-formatted [-Wclang-format-violations] static const char igb_driver_string[] = ^ drivers/net/ethernet/intel/igb/igb_main.c:56:36: warning: code should be clang-formatted [-Wclang-format-violations] static const char igb_copyright[] = ^ drivers/net/ethernet/intel/igb/igb_main.c:100:3: warning: code should be clang-formatted [-Wclang-format-violations] {0, } ^ drivers/net/ethernet/intel/igb/igb_main.c:100:5: warning: code should be clang-formatted [-Wclang-format-violations] {0, } ^ drivers/net/ethernet/intel/igb/igb_main.c:163:58: warning: code should be clang-formatted [-Wclang-format-violations] static int igb_ndo_set_vf_vlan(struct net_device *netdev, ^ drivers/net/ethernet/intel/igb/igb_main.c:164:28: warning: code should be clang-formatted [-Wclang-format-violations] int vf, u16 vlan, u8 qos, __be16 vlan_proto); ^ drivers/net/ethernet/intel/igb/igb_main.c:189:50: warning: code should be clang-formatted [-Wclang-format-violations] SET_SYSTEM_SLEEP_PM_OPS(igb_suspend, igb_resume) ^ drivers/net/ethernet/intel/igb/igb_main.c:190:21: warning: code should be clang-formatted [-Wclang-format-violations] SET_RUNTIME_PM_OPS(igb_runtime_suspend, igb_runtime_resume, ^ drivers/net/ethernet/intel/igb/igb_main.c:190:61: warning: code should be clang-formatted [-Wclang-format-violations]
vs
$ ./scripts/checkpatch.pl -f drivers/net/ethernet/intel/igb/igb_main.c 2>&1 | head -25 WARNING: externs should be avoided in .c files #113: FILE: drivers/net/ethernet/intel/igb/igb_main.c:113: +int igb_open(struct net_device *);
WARNING: function definition argument 'struct net_device *' should also have an identifier name #113: FILE: drivers/net/ethernet/intel/igb/igb_main.c:113: +int igb_open(struct net_device *);
WARNING: externs should be avoided in .c files #114: FILE: drivers/net/ethernet/intel/igb/igb_main.c:114: +int igb_close(struct net_device *);
WARNING: function definition argument 'struct net_device *' should also have an identifier name #114: FILE: drivers/net/ethernet/intel/igb/igb_main.c:114: +int igb_close(struct net_device *);
CHECK: Alignment should match open parenthesis #191: FILE: drivers/net/ethernet/intel/igb/igb_main.c:191: + SET_RUNTIME_PM_OPS(igb_runtime_suspend, igb_runtime_resume, + igb_runtime_idle)
CHECK: Please use a blank line after function/struct/union/enum declarations #193: FILE: drivers/net/ethernet/intel/igb/igb_main.c:193: +}; +static void igb_shutdown(struct pci_dev *);
| |