lkml.org 
[lkml]   [2020]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 08/12] usb: hosts: Remove in_interrupt() from comments
    On Wed, Oct 14, 2020 at 04:52:23PM +0200, Thomas Gleixner wrote:
    > From: Ahmed S. Darwish <a.darwish@linutronix.de>
    >
    > The usage of in_interrupt() in drivers is phased out for various reasons.
    >
    > Various comments use !in_interrupt() to describe calling context for probe()
    > and remove() functions. That's wrong because the calling context has to be
    > preemptible task context, which is not what !in_interrupt() describes.
    >
    > Cleanup the comments. While at it add the missing kernel doc argument
    > descriptors and make usb_hcd_msp_remove() static.
    >
    > Signed-off-by: Ahmed S. Darwish <a.darwish@linutronix.de>
    > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    > Cc: Alan Stern <stern@rowland.harvard.edu>
    > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > Cc: linux-usb@vger.kernel.org
    > Cc: linux-omap@vger.kernel.org
    > Cc: Kukjin Kim <kgene@kernel.org>
    > Cc: Krzysztof Kozlowski <krzk@kernel.org>
    > Cc: linux-arm-kernel@lists.infradead.org
    > Cc: linux-samsung-soc@vger.kernel.org
    >
    > ---
    > drivers/usb/host/ehci-fsl.c | 9 ++++-----
    > drivers/usb/host/ehci-pmcmsp.c | 15 +++++++++------
    > drivers/usb/host/ohci-at91.c | 11 ++++++++---
    > drivers/usb/host/ohci-omap.c | 7 ++++---
    > drivers/usb/host/ohci-pxa27x.c | 11 ++++++-----
    > drivers/usb/host/ohci-s3c2410.c | 12 ++++++------

    For the s3c2410:
    Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2020-10-14 17:25    [W:2.589 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site