Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 14 Oct 2020 16:51:51 +0200 | Subject | Re: [PATCH v3 4/5] media: dt-bindings: media: renesas,drif: Add r8a77965 support |
| |
Hi Fabrizio,
On Wed, Oct 14, 2020 at 4:35 PM Fabrizio Castro <fabrizio.castro.jz@renesas.com> wrote: > > From: Geert Uytterhoeven <geert@linux-m68k.org> > > On Tue, Oct 13, 2020 at 5:02 PM Fabrizio Castro > > <fabrizio.castro.jz@renesas.com> wrote: > > > The r8a77965 (a.k.a. R-Car M3-N) device tree schema is > > > compatible with the already documented R-Car Gen3 devices. > > > > > > Document r8a77965 support within renesas,drif.yaml. > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > > > > Thanks for your patch! > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > > --- a/Documentation/devicetree/bindings/media/renesas,drif.yaml > > > +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml > > > @@ -53,6 +53,7 @@ properties: > > > - enum: > > > - renesas,r8a7795-drif # R-Car H3 > > > - renesas,r8a7796-drif # R-Car M3-W > > > + - renesas,r8a77965-drif # R-Car M3-N > > > - renesas,r8a77990-drif # R-Car E3 > > > - const: renesas,rcar-gen3-drif # Generic R-Car Gen3 compatible device > > > > I guess you're aware M3-N (and E3) have an extra register? > > Probably the driver just relies on its initial value, but it never hurts to be > > explicit and initialize it properly. > > Yes, I am aware of the extra register, and that's reflected in the DRIF nodes > definition within the SoC specific device trees. > I'll tackle initialization and configuration of the extra register at some point, > do you think we could use the default value for now?
Yes, that's fine for me, if it works with the current driver.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |