Messages in this thread | | | Date | Wed, 14 Oct 2020 10:04:01 -0400 | From | Sasha Levin <> | Subject | Re: [PATCH AUTOSEL 5.8 18/24] net: usb: rtl8150: set random MAC address when set_ethernet_addr() fails |
| |
On Tue, Oct 13, 2020 at 12:01:06AM +0300, Petko Manolov wrote: >On 20-10-12 12:11:18, Joe Perches wrote: >> On Mon, 2020-10-12 at 15:02 -0400, Sasha Levin wrote: >> > From: Anant Thazhemadam <anant.thazhemadam@gmail.com> >> > >> > [ Upstream commit f45a4248ea4cc13ed50618ff066849f9587226b2 ] >> > >> > When get_registers() fails in set_ethernet_addr(),the uninitialized >> > value of node_id gets copied over as the address. >> > So, check the return value of get_registers(). >> > >> > If get_registers() executed successfully (i.e., it returns >> > sizeof(node_id)), copy over the MAC address using ether_addr_copy() >> > (instead of using memcpy()). >> > >> > Else, if get_registers() failed instead, a randomly generated MAC >> > address is set as the MAC address instead. >> >> This autosel is premature. >> >> This patch always sets a random MAC. >> See the follow on patch: https://lkml.org/lkml/2020/10/11/131 >> To my knowledge, this follow-ob has yet to be applied: > >ACK, the follow-on patch has got the correct semantics.
I'll hold off on this patch until the follow-on is merged, thanks!
-- Thanks, Sasha
| |