Messages in this thread | | | Subject | Re: [PATCH v3 2/3] pinctrl: rockchip: enable gp io pclk for rockchip gpio to irq【请注意, 邮件由linux-rockchip-bounces+kever.yang=rock- =?UTF-8?B?Y2hpcHMuY29tQGxpc3Rz | From | Kever Yang <> | Date | Wed, 14 Oct 2020 08:23:56 +0800 |
| |
On 2020/10/13 下午2:37, Jianqun Xu wrote: > There need to enable pclk_gpio when do irq_create_mapping, since it will > do access to gpio controller. > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> > --- > drivers/pinctrl/pinctrl-rockchip.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c > index 927d132d6716..a2f361aa6d05 100644 > --- a/drivers/pinctrl/pinctrl-rockchip.c > +++ b/drivers/pinctrl/pinctrl-rockchip.c > @@ -3157,7 +3157,9 @@ static int rockchip_gpio_to_irq(struct gpio_chip *gc, unsigned offset) > if (!bank->domain) > return -ENXIO; > > + clk_enable(bank->clk); > virq = irq_create_mapping(bank->domain, offset); > + clk_disable(bank->clk); > > return (virq) ? : -ENXIO; > }
Looks good to me,
Reviewed-by: Kever Yang<kever.yang@rock-chips.com>
Thanks, - Kever
| |