Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 13 Oct 2020 15:27:10 +0200 | Subject | Re: [RFC PATCH 2/3] dt-bindings: gpio: Add binding documentation for Etron EJ168/EJ188/EJ198 |
| |
On Wed, Oct 7, 2020 at 9:58 PM Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > On Wed, Oct 7, 2020 at 11:19 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Sun, Oct 4, 2020 at 8:00 PM Martin Blumenstingl > > <martin.blumenstingl@googlemail.com> wrote: > > > > > +properties: > > > + compatible: > > > + enum: > > > + - pci1b6f,7023 > > > + - pci1b6f,7052 > > > > I think it is better to let the PCI driver for the whole hardware in > > drivers/usb/host/xhci-pci.c probe from the PCI configuration space > > numbers, and then add a gpio_chip to xhci-pci.c. > > to have everything consistent I will move the binding to > Documentation/devicetree/bindings/usb
I do not understand why a PCI device would need a DT binding at all. They just probe from the magic number in the PCI config space, they spawn struct pci_dev PCI devices, not the type of platform devices coming out of the DT parser code. No DT compatible needed.
What am I not understanding about this?
Yours, Linus Walleij
| |