Messages in this thread | | | Subject | Re: [PATCH next] iommu: intel: don't dereference iommu_device if IOMMU_API is not built | From | David Woodhouse <> | Date | Tue, 13 Oct 2020 10:16:58 +0100 |
| |
On Tue, 2020-10-13 at 09:30 +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > Since commit c40aaaac1018 ("iommu/vt-d: Gracefully handle DMAR units > with no supported address widths") dmar.c needs struct iommu_device to > be selected. We can drop this dependency by not dereferencing struct > iommu_device if IOMMU_API is not selected and by reusing the information > stored in iommu->drhd->ignored instead. > > This fixes the following build error when IOMMU_API is not selected: > > drivers/iommu/intel/dmar.c: In function ‘free_iommu’: > drivers/iommu/intel/dmar.c:1139:41: error: ‘struct iommu_device’ has no member named ‘ops’ > 1139 | if (intel_iommu_enabled && iommu->iommu.ops) { > ^ > > Fixes: c40aaaac1018 ("iommu/vt-d: Gracefully handle DMAR units with no supported address widths") > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Oops, apologies for that. Thanks for fixing it.
Acked-by: David Woodhouse <dwmw@amazon.co.uk>
[unhandled content-type:application/x-pkcs7-signature] | |