Messages in this thread | | | Date | Tue, 13 Oct 2020 10:37:27 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH v8 3/3] leds: trigger: implement a tty trigger |
| |
Hello,
On Mon, Oct 12, 2020 at 10:16:59PM +0800, kernel test robot wrote: > Hi "Uwe,
I love your test report! Perhaps something to improve: The parser of the From: line should drop the " :-)
> drivers/leds/trigger/ledtrig-tty.c: In function 'ledtrig_tty_work': > >> drivers/leds/trigger/ledtrig-tty.c:92:7: warning: variable 'firstrun' set but not used [-Wunused-but-set-variable] > 92 | bool firstrun = false; > | ^~~~~~~~
Indeed, this line should just be dropped. I won't resend yet, waiting for some feedback first and assuming reviewers are able to interpolate how v9 will look like :-)
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |