lkml.org 
[lkml]   [2020]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 029/124] gpiolib: Disable compat ->read() code in UML case
    Date
    From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

    commit 47e538d86d5776ac8152146c3ed3d22326243190 upstream.

    It appears that UML (arch/um) has no compat.h header defined and hence
    can't compile a recently provided piece of code in GPIO library.

    Disable compat ->read() code in UML case to avoid compilation errors.

    While at it, use pattern which is already being used in the kernel elsewhere.

    Fixes: 5ad284ab3a01 ("gpiolib: Fix line event handling in syscall compatible mode")
    Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Link: https://lore.kernel.org/r/20201005131044.87276-1-andriy.shevchenko@linux.intel.com
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpio/gpiolib.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/gpio/gpiolib.c
    +++ b/drivers/gpio/gpiolib.c
    @@ -838,7 +838,7 @@ static __poll_t lineevent_poll(struct fi

    static ssize_t lineevent_get_size(void)
    {
    -#ifdef __x86_64__
    +#if defined(CONFIG_X86_64) && !defined(CONFIG_UML)
    /* i386 has no padding after 'id' */
    if (in_ia32_syscall()) {
    struct compat_gpioeevent_data {

    \
     
     \ /
      Last update: 2020-10-12 15:55    [W:3.698 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site