Messages in this thread | | | From | Coiby Xu <> | Date | Mon, 12 Oct 2020 19:29:14 +0800 | Subject | Re: [PATCH v1 5/6] staging: qlge: clean up debugging code in the QL_ALL_DUMP ifdef land |
| |
On Sat, Oct 10, 2020 at 10:40:55PM +0900, Benjamin Poirier wrote: >On 2020-10-10 18:00 +0800, Coiby Xu wrote: >[...] >> > >> > Please also update drivers/staging/qlge/TODO accordingly. There is still >> > a lot of debugging code IMO (the netif_printk statements - kernel >> > tracing can be used instead of those) but this patch is a substantial >> > improvement. >> >> Thank you for the reminding! To move qlge out of staging tree would be >> interesting exercise for me:) > >If you would like to work more on the driver, I would highly suggest >getting one or two adapters to be able to test your changes. They can be >had for relatively cheap on ebay. Just search for "qle8142".
Thank you for the info! Right now I don't have a desktop to install this kind of adapter. I'll get one after settling the plan for a desktop.
-- Best regards, Coiby
| |