Messages in this thread | | | From | Linus Torvalds <> | Date | Mon, 12 Oct 2020 14:10:10 -0700 | Subject | Re: [GIT PULL] x86/platform updates for v5.10 |
| |
On Mon, Oct 12, 2020 at 3:10 AM Borislav Petkov <bp@suse.de> wrote: > > please pull the x86/platform queue.
Hmm. I didn't immediately notice this new warning, because it only happens with the clang build that I don't do in between every pull.
But this pull causes new warnings from clang:
arch/x86/platform/uv/uv_nmi.c:250:23: warning: implicit conversion from 'unsigned long' to 'int' changes value from 1152921504606846976 to 0 [-Wconstant-conversion] uvh_nmi_mmrx_mask = UVH_EVENT_OCCURRED0_EXTIO_INT0_MASK; ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
and I think that warning is correct, and the code is wrong.
In particular, we have
static int uvh_nmi_mmrx_mask;
so it's a signed 32-bit integer, and the code is treating it like it's a 64-bit mask.
Of course, it also looks like that 'uvh_nmi_mmrx_mask' thing is a write-only variable so it doesn't matter, but can we _please_ get this code fixed ASAP?
Linus
| |