lkml.org 
[lkml]   [2020]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property
    From
    Date
    Hi,

    On 11/10/2020 00:41, Serge Semin wrote:
    > An empty snps,quirk-frame-length-adjustment won't cause any change
    > performed by the driver. Moreover the DT schema validation will fail,
    > since it expects the property being assigned with some value. So just
    > discard the property declaration then from the example.
    >
    > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
    >
    > ---
    >
    > Note the same problem is in the DT source file
    > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi .
    > ---
    > .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 1 -
    > 1 file changed, 1 deletion(-)
    >
    > diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml
    > index 5b04a7dfa018..88184d7e26cc 100644
    > --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml
    > +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml
    > @@ -209,6 +209,5 @@ examples:
    > interrupts = <30>;
    > dr_mode = "host";
    > snps,dis_u2_susphy_quirk;
    > - snps,quirk-frame-length-adjustment;
    > };
    > };
    >

    Thanks for reporting this, actually the fladj must be 0x20 on this hw,
    but we do set this on the PHY side, so we can let the dwc3 side 0 here.

    Acked-by: Neil Armstrong <narmstrong@baylibre.com>

    Neil

    \
     
     \ /
      Last update: 2020-10-12 09:55    [W:5.088 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site