Messages in this thread | | | Date | Mon, 12 Oct 2020 11:13:24 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 0/5] tracing: Synthetic event dynamic string fixes |
| |
On Fri, 9 Oct 2020 10:17:06 -0500 Tom Zanussi <zanussi@kernel.org> wrote:
> These patches provide fixes for the problems observed by Masami in the > new synthetic event dynamic string patchset. > > The first patch (tracing: Don't show dynamic string internals in > synthetic event description) removes the __data_loc from the event > description but leaves it in the format. > > The patch (tracing: Add synthetic event error logging) addresses the > lack of error messages when parse errors occur. > > The remaining three patches address the other problems Masami noted > which result from allowing illegal characters in synthetic event and > field names when defining an event. The is_good_name() function is > used to check that's not possible for the probe events, but should > also be used for the synthetic events as well. > > (tracing: Move is_good_name() from trace_probe.h to trace.h) makes > that function available to other trace subsystems by putting it in > trace.h. (tracing: Check that the synthetic event and field names are > legal) applies it to the synthetic events, and (selftests/ftrace: > Change synthetic event name for inter-event-combined test) changes a > testcase that now fails because it uses an illegal name. >
Hi Tom,
Would you be able to address Masami's concerns on patches 1 and 4?
-- Steve
| |