Messages in this thread | | | Subject | Re: [RFC PATCH] checkpatch: add shebang check to EXECUTE_PERMISSIONS | From | Joe Perches <> | Date | Mon, 12 Oct 2020 08:08:24 -0700 |
| |
On Mon, 2020-10-12 at 19:22 +0530, Ujjwal Kumar wrote: > On 12/10/20 11:47 am, Joe Perches wrote: > > On Mon, 2020-10-12 at 11:19 +0530, Ujjwal Kumar wrote: > > > checkpatch.pl checks for invalid EXECUTE_PERMISSIONS on source > > > files. The script leverages filename extensions and its path in > > > the repository to decide whether to allow execute permissions on > > > the file or not. > > > > > > Based on current check conditions, a perl script file having > > > execute permissions, without '.pl' extension in its filename > > > and not belonging to 'scripts/' directory is reported as ERROR > > > which is a false-positive. > > > > > > Adding a shebang check along with current conditions will make > > > the check more generalised and improve checkpatch reports. > > > To do so, without breaking the core design decision of checkpatch, > > > we can fetch the first line from the patch itself and match it for > > > a shebang pattern. > > > > > > There can be cases where the first line is not part of the patch. > > > > For instance: a patch that only changes permissions > > without changing any of the file content.
Please add verbiage like this to the commit message.
> Should these new changes go as a separate patch or can they be > included in the next iteration of this patch?
V2 please.
| |