lkml.org 
[lkml]   [2020]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] nfsd: remove unneeded break
On Sun, Oct 11, 2020 at 08:51:55AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Because every path through nfs4_find_file()'s
> switch does an explicit return, the break is not needed.

OK, applying.--b.

>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> fs/nfsd/nfs4state.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index c09a2a4281ec..741f64672d96 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -5722,7 +5722,6 @@ nfs4_find_file(struct nfs4_stid *s, int flags)
> return find_readable_file(s->sc_file);
> else
> return find_writeable_file(s->sc_file);
> - break;
> }
>
> return NULL;
> --
> 2.18.1

\
 
 \ /
  Last update: 2020-10-12 16:21    [W:0.033 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site