Messages in this thread | | | Date | Sat, 10 Oct 2020 21:27:21 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [PATCH] coccinelle: api: kfree_sensitive: print memset position |
| |
On Fri, 9 Oct 2020, Denis Efremov wrote:
> Print memset() call position in addition to the kfree() position to > ease issues identification. > > Signed-off-by: Denis Efremov <efremov@linux.com>
Applied, thanks.
julia
> --- > scripts/coccinelle/api/kfree_sensitive.cocci | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/scripts/coccinelle/api/kfree_sensitive.cocci b/scripts/coccinelle/api/kfree_sensitive.cocci > index e4a066a0b77d..8d980ebf3223 100644 > --- a/scripts/coccinelle/api/kfree_sensitive.cocci > +++ b/scripts/coccinelle/api/kfree_sensitive.cocci > @@ -85,14 +85,16 @@ type T; > > @script:python depends on report@ > p << r.p; > +m << r.m; > @@ > > -coccilib.report.print_report(p[0], > - "WARNING: opportunity for kfree_sensitive/kvfree_sensitive") > +msg = "WARNING opportunity for kfree_sensitive/kvfree_sensitive (memset at line %s)" > +coccilib.report.print_report(p[0], msg % (m[0].line)) > > @script:python depends on org@ > p << r.p; > +m << r.m; > @@ > > -coccilib.org.print_todo(p[0], > - "WARNING: opportunity for kfree_sensitive/kvfree_sensitive") > +msg = "WARNING opportunity for kfree_sensitive/kvfree_sensitive (memset at line %s)" > +coccilib.org.print_todo(p[0], msg % (m[0].line)) > -- > 2.26.2 > >
| |