lkml.org 
[lkml]   [2020]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 04/18] dmaengine: idxd: add interrupt handle request support
From
Date


On 9/30/2020 11:36 AM, Thomas Gleixner wrote:
> On Tue, Sep 15 2020 at 16:28, Dave Jiang wrote:
>>
>> +#define INT_HANDLE_IMS_TABLE 0x10000
>> +int idxd_device_request_int_handle(struct idxd_device *idxd, int idx,
>> + int *handle, enum idxd_interrupt_type irq_type)
>
> New lines exist for a reason and this glued together define and function
> definition is unreadable garbage.
>
> Also is that magic bit a software flag or defined by hardware? If the
> latter then you want to move it to the other hardware defines.

Will move this to hardware register header.

>
> Thanks,
>
> tglx
>
>

\
 
 \ /
  Last update: 2020-10-01 22:16    [W:0.032 / U:5.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site