lkml.org 
[lkml]   [2020]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles
From
Date
Hello Krzysztof,

On 9/30/20 9:01 PM, Krzysztof Kozlowski wrote:
> There are four flavors of TechNexion PICO-IMX6 boards. They have their
> own DTSes, even though in Dwarf, Nymph and Pi are exactly the same.
> They also have their own bindings so adjust the compatibles to match the
> bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Changes since v1:
> 1. None
> ---
> arch/arm/boot/dts/imx6dl-pico-dwarf.dts | 2 +-
> arch/arm/boot/dts/imx6dl-pico-hobbit.dts | 2 +-
> arch/arm/boot/dts/imx6dl-pico-nymph.dts | 2 +-
> arch/arm/boot/dts/imx6dl-pico-pi.dts | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6dl-pico-dwarf.dts b/arch/arm/boot/dts/imx6dl-pico-dwarf.dts
> index 659a8e8714ea..d85b15a8c127 100644
> --- a/arch/arm/boot/dts/imx6dl-pico-dwarf.dts
> +++ b/arch/arm/boot/dts/imx6dl-pico-dwarf.dts
> @@ -13,5 +13,5 @@
>
> / {
> model = "TechNexion PICO-IMX6 DualLite/Solo Board and Dwarf baseboard";
> - compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
> + compatible = "technexion,imx6dl-pico-dwarf", "fsl,imx6dl";

Could you change this to have all three compatibles ("technexion,imx6dl-pico-dwarf", "technexion,imx6dl-pico",
"fsl,imx6dl") and likewise for the other files?
That way other firmware that reuses the Linux device tree files and match against the SoM compatible
continues to work after update.

> };
> diff --git a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts
> index d7403c5c4337..08fedcbcc91b 100644
> --- a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts
> +++ b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts
> @@ -13,5 +13,5 @@
>
> / {
> model = "TechNexion PICO-IMX6 DualLite/Solo Board and Hobbit baseboard";
> - compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
> + compatible = "technexion,imx6dl-pico-hobbit", "fsl,imx6dl";
> };
> diff --git a/arch/arm/boot/dts/imx6dl-pico-nymph.dts b/arch/arm/boot/dts/imx6dl-pico-nymph.dts
> index b282dbf953aa..32ccfc5d41ce 100644
> --- a/arch/arm/boot/dts/imx6dl-pico-nymph.dts
> +++ b/arch/arm/boot/dts/imx6dl-pico-nymph.dts
> @@ -13,5 +13,5 @@
>
> / {
> model = "TechNexion PICO-IMX6 DualLite/Solo Board and Nymph baseboard";
> - compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
> + compatible = "technexion,imx6dl-pico-nymph", "fsl,imx6dl";
> };
> diff --git a/arch/arm/boot/dts/imx6dl-pico-pi.dts b/arch/arm/boot/dts/imx6dl-pico-pi.dts
> index b7b1c07f96f3..4590e8ad9a91 100644
> --- a/arch/arm/boot/dts/imx6dl-pico-pi.dts
> +++ b/arch/arm/boot/dts/imx6dl-pico-pi.dts
> @@ -13,5 +13,5 @@
>
> / {
> model = "TechNexion PICO-IMX6 DualLite/Solo Board and PI baseboard";
> - compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
> + compatible = "technexion,imx6dl-pico-pi", "fsl,imx6dl";
> };
>

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

\
 
 \ /
  Last update: 2020-10-01 09:23    [W:0.136 / U:1.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site