Messages in this thread | | | Date | Thu, 1 Oct 2020 12:07:53 -0700 | From | Moritz Fischer <> | Subject | Re: [PATCH v1 01/12] fpga: fpga security manager class driver |
| |
Hi Russ,
On Wed, Sep 30, 2020 at 06:07:00PM -0700, Russ Weight wrote: > > Hi Moritz, > > On 9/30/20 5:31 PM, Moritz Fischer wrote: > > I think providing the devm_ managed APIs is nicer, and makes it easier > > for the consumer of the API to do the right thing. > > I see that the fpga_mgr code has support for two versions of the create() > and register() functions, one uses the devm_ approach, and the other does > not. Would also want to have two versions for the security manager?
The devm_fpga_mgr_create() just wraps the other one. I think that's a good way to handle it for now.
I'd keep the breakdown the same.
Cheers, Moritz
| |