Messages in this thread | | | Subject | Re: [PATCH v1] PCI: brcmstb: fix error return paths in probe() | From | Florian Fainelli <> | Date | Thu, 1 Oct 2020 11:51:32 -0700 |
| |
On 10/1/2020 8:18 AM, Jim Quinlan wrote: > Fixes two cases where we were returning without calling > clk_disable_unprepare(). Although there is a common place to go on probe() > errors (the 'fail' label), one can only jump there after executing > brcm_pcie_setup(), so we have to add clk_disable_unprepare() calls to the > two error paths. > > Fixes: b98f52bc6495 ("PCI: brcmstb: Add control of rescal reset") > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |