Messages in this thread |  | | Date | Thu, 1 Oct 2020 08:16:39 -0700 | From | Guenter Roeck <> | Subject | Re: [v5,0/4] watchdog: mt8192: add wdt support |
| |
On Thu, Oct 01, 2020 at 04:23:02PM +0200, Matthias Brugger wrote: > Hi Crystal, > > It seems you forgot to send the email to one of the maintainers, Wim. > Please make sure you add all the maintainers from get_maintainers.pl when > you send a series. > > Regards, > Matthias > > On 29/09/2020 05:20, Crystal Guo wrote: > > v5 changes: > > fix typos on: > > https://patchwork.kernel.org/patch/11697493/ > > > > v4 changes: > > revise commit messages. > > > > v3 changes: > > https://patchwork.kernel.org/patch/11692731/ > > https://patchwork.kernel.org/patch/11692767/ > > https://patchwork.kernel.org/patch/11692729/ > > https://patchwork.kernel.org/patch/11692771/ > > https://patchwork.kernel.org/patch/11692733/
This is less than helpful. It doesn't tell me anything. It expects me to go back to the earlier versions, download them, and run a diff, to figure out what changed. That means the patch or patch series ends at the bottom of my pile of patches to review. Which, as it happens, is quite deep.
I will review this and similar patches without change log after (and only after) I have reviewed all other patches in my queue.
Guenter
> > > > Crystal Guo (4): > > dt-binding: mediatek: watchdog: fix the description of compatible > > dt-binding: mediatek: mt8192: update mtk-wdt document > > dt-binding: mt8192: add toprgu reset-controller head file > > watchdog: mt8192: add wdt support > > > > .../devicetree/bindings/watchdog/mtk-wdt.txt | 5 ++-- > > drivers/watchdog/mtk_wdt.c | 6 +++++ > > .../dt-bindings/reset-controller/mt8192-resets.h | 30 ++++++++++++++++++++++ > > 3 files changed, 39 insertions(+), 2 deletions(-) > > create mode 100644 include/dt-bindings/reset-controller/mt8192-resets.h > >
|  |