lkml.org 
[lkml]   [2020]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL][PATCH v4 0/9] Update to zstd-1.4.6
On Wed, Sep 30, 2020 at 08:49:49PM +0000, Nick Terrell wrote:
> > On Sep 29, 2020, at 11:53 PM, Nick Terrell <nickrterrell@gmail.com> wrote:
> >
> > From: Nick Terrell <terrelln@fb.com>
>
> It has been brought to my attention that patch 3 hasn’t made it to patchwork,
> likely because it is too large. I’ll include a pull request in the next cover letter,
> together with the patches (if needed).

The patch 3/9 saved to a file is 1.6M, over 35000 lines, the diffstat
says:

66 files changed, 24268 insertions(+), 12889 deletions(-)

Seriously, this is wrong in so many ways. There's the rationale for
one-time change etc, but the actual result is beyond what I would accept
and would not encourage anyone to merge as-is.

\
 
 \ /
  Last update: 2020-10-01 12:20    [W:0.130 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site