lkml.org 
[lkml]   [2020]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v14 03/15] mtd: spi-nor: add support for DTR protocol
Date
On 10/1/20 11:37 AM, Pratyush Yadav wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 01/10/20 07:46AM, Tudor.Ambarus@microchip.com wrote:
>> On 9/30/20 9:57 PM, Pratyush Yadav wrote:
>>> @@ -2387,12 +2496,16 @@ spi_nor_spimem_adjust_hwcaps(struct spi_nor
>>> *nor, u32 *hwcaps)
>>> struct spi_nor_flash_parameter *params = nor->params;
>>> unsigned int cap;
>>>
>>> - /* DTR modes are not supported yet, mask them all. */
>>> - *hwcaps &= ~SNOR_HWCAPS_DTR;
>>> -
>>> /* X-X-X modes are not supported yet, mask them all. */
>>> *hwcaps &= ~SNOR_HWCAPS_X_X_X;
>>>
>>> + /*
>>> + * If the reset line is broken, we do not want to enter a stateful
>>> + * mode.
>>> + */
>>> + if (nor->flags & SNOR_F_BROKEN_RESET)
>>> + *hwcaps &= ~(SNOR_HWCAPS_X_X_X | SNOR_HWCAPS_X_X_X_DTR);
>>
>> SNOR_HWCAPS_X_X_X is already masked out above. Do we need to do it again?
>
> That might change later and the person removing that line might not
> remember or even know to add it back here.

ok
\
 
 \ /
  Last update: 2020-10-01 10:50    [W:0.123 / U:3.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site