lkml.org 
[lkml]   [2020]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] phy: qcom-qmp: initialize the pointer to NULL
On 01-10-20, 00:23, Stephen Boyd wrote:
> Quoting Vinod Koul (2020-10-01 00:09:11)
> > Smatch complains:
> > drivers/phy/qualcomm/phy-qcom-qmp.c:3899 qcom_qmp_phy_probe() error: uninitialized symbol 'dp_cfg'.
> > drivers/phy/qualcomm/phy-qcom-qmp.c:3900 qcom_qmp_phy_probe() error: uninitialized symbol 'dp_serdes'.
> > drivers/phy/qualcomm/phy-qcom-qmp.c:3902 qcom_qmp_phy_probe() error: uninitialized symbol 'usb_cfg'.
> >
> > This is a warning but not a practical one as dp_cfg, dp_serdes and
> > usb_cfg will be set and used when valid. So we can set the pointers to
> > NULL to quiesce the warnings.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Fixes: 52e013d0bffa ("phy: qcom-qmp: Add support for DP in USB3+DP combo phy")
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
>
> Thanks!
>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>

Thanks for quick review, applied and pushed now

--
~Vinod

\
 
 \ /
  Last update: 2020-10-01 09:37    [W:0.295 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site