lkml.org 
[lkml]   [2020]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/7] mm: kmem: remove duplicate definitions of __memcg_kmem_(un)charge()
On Thu, 9 Jan 2020 09:27:39 -0800 Roman Gushchin <guro@fb.com> wrote:

> For some reason these inline functions are defined twice. Remove
> the second identical copy.

Don't think so - that wouldn't have compiled.

> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -1438,15 +1438,6 @@ static inline void memcg_kmem_uncharge(struct page *page, int order)
> {
> }
>
> -static inline int __memcg_kmem_charge(struct page *page, gfp_t gfp, int order)
> -{
> - return 0;
> -}
> -
> -static inline void __memcg_kmem_uncharge(struct page *page, int order)
> -{
> -}
> -
> #define for_each_memcg_cache_index(_idx) \
> for (; NULL; )
>

Maybe you confused these with memcg_kmem_charge() and
memcg_kmem_uncharge()?

\
 
 \ /
  Last update: 2020-01-09 20:41    [W:0.066 / U:31.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site