lkml.org 
[lkml]   [2020]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[tip: irq/core] genirq: Add missing __must_hold() sparse annotation
The following commit has been merged into the irq/core branch of tip:

Commit-ID: 099368bb10c0e340f0b236b169e8b13235e0907c
Gitweb: https://git.kernel.org/tip/099368bb10c0e340f0b236b169e8b13235e0907c
Author: Jules Irenge <jbi.octave@gmail.com>
AuthorDate: Mon, 16 Dec 2019 14:42:08
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Thu, 09 Jan 2020 18:03:37 +01:00

genirq: Add missing __must_hold() sparse annotation

Add __must_hold() annotation to address the following sparse warning:

warning: context imbalance in irq_wait_for_poll - unexpected unlock

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20191216144208.29852-2-jbi.octave@gmail.com
---
kernel/irq/spurious.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c
index 2ed97a7..f865e5f 100644
--- a/kernel/irq/spurious.c
+++ b/kernel/irq/spurious.c
@@ -34,6 +34,7 @@ static atomic_t irq_poll_active;
* true and let the handler run.
*/
bool irq_wait_for_poll(struct irq_desc *desc)
+ __must_hold(&desc->lock)
{
if (WARN_ONCE(irq_poll_cpu == smp_processor_id(),
"irq poll in progress on cpu %d for irq %d\n",
\
 
 \ /
  Last update: 2020-01-09 18:11    [W:0.086 / U:3.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site