lkml.org 
[lkml]   [2020]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] spi: sh-msiof: Do not redefine STR while compile testing
Hi Krzysztof,

On Wed, Jan 8, 2020 at 8:43 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> STR is a well-known stringify macro so it should be avoided in drivers
> to avoid warnings like this (MIPS architecture while compile testing):
>
> drivers/spi/spi-sh-msiof.c:76:0: warning: "STR" redefined
> #define STR 0x40 /* Status Register */
> arch/mips/include/asm/mipsregs.h:30:0: note: this is the location of the previous definition
> #define STR(x) __STR(x)
>
> To maintain consistency between all register names add a SI prefix to
> all of them. This also matches register names in datasheet.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Changes since v1:
> 1. Use SI prefix,
> 2. Adjust all register names.

Thanks for the update!

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

No changes in object file, so:
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2020-01-09 13:44    [W:4.344 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site