lkml.org 
[lkml]   [2020]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 0/4] usb: xhci: Add support for Renesas USB controllers
On 08-01-20, 19:29, Greg Kroah-Hartman wrote:
> On Wed, Jan 08, 2020 at 06:00:48PM +0200, Mathias Nyman wrote:

> >
> > Reviewing this always got bumped down on my todo list as other urgent issues
> > came up.
> >
> > I think the concern about adding this amount of renesas specific code to
> > xhci-pci.c is valid. This series adds over 900 lines of Renesas FW loading
> > code to a 600 line xhci-pci.c
>
> Yeah, that's not good, should be simple to split it into a separate file
> that's only build if that hardware is selected.

Okay let me redo the patches splitting it up. If you have any thoughts
about how that should be done, do let me know.

Thanks
--
~Vinod

\
 
 \ /
  Last update: 2020-01-09 13:10    [W:0.038 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site