Messages in this thread | | | Subject | Re: [PATCH] clocksource: timer-ti-dm: Fix regression | From | Daniel Lezcano <> | Date | Thu, 9 Jan 2020 12:42:37 +0100 |
| |
On 06/01/2020 21:37, Tony Lindgren wrote: > Clean-up commit 8c82723414d5 ("clocksource/drivers/timer-ti-dm: Switch to > platform_get_irq") caused a regression where we now try to access > uninitialized data for timer: > > drivers/clocksource/timer-ti-dm.c: In function 'omap_dm_timer_probe': > drivers/clocksource/timer-ti-dm.c:798:13: warning: 'timer' may be used > uninitialized in this function [-Wmaybe-uninitialized] > > On boot we now get: > > Unable to handle kernel NULL pointer dereference at virtual address > 00000004 > ... > (omap_dm_timer_probe) from [<c061ac7c>] (platform_drv_probe+0x48/0x98) > (platform_drv_probe) from [<c0618c04>] (really_probe+0x1dc/0x348) > (really_probe) from [<c0618ef4>] (driver_probe_device+0x5c/0x160) > > Let's fix the issue by moving platform_get_irq to happen after timer has > been allocated. > > Fixes: 8c82723414d5 ("clocksource/drivers/timer-ti-dm: Switch to platform_get_irq") > Cc: Yangtao Li <tiny.windzz@gmail.com> > Signed-off-by: Tony Lindgren <tony@atomide.com> > ---
Applied, thanks.
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |