lkml.org 
[lkml]   [2020]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [GIT PULL] HID fixes
On Thu, Jan 9, 2020 at 3:36 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> Now, good source code presumably notices EPOLLERR and handles it. So
> it _shouldn't_ matter what the kernel does if an error occurs. I
> haven't checked what people _actually_ do, tnough. I worry sometimes
> that user space just looks at EPOLLIN sees it not being set, and gets
> stuck in a busy loop polling in case of errors.

Googling around for it, I find this, for example:

https://github.com/scylladb/seastar/issues/309

and yes, I think that's technically a user space bug, but it's very
much an example of this: they expect to get errors through read() or
write() calls, and get confused when poll() does not say that the fd
is readable or writable.

I don't know how common this is, but it didn't take a _lot_ of
googling for me to find that one..

Linus

\
 
 \ /
  Last update: 2020-01-10 00:42    [W:0.026 / U:11.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site