lkml.org 
[lkml]   [2020]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 10/36] platform/x86: intel_scu_ipc: Drop intel_scu_ipc_io[read|write][8|16]()
On Wed, Jan 08, 2020 at 02:41:35PM +0300, Mika Westerberg wrote:
> There are no users for these so we can remove them.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> arch/x86/include/asm/intel_scu_ipc.h | 12 -----
> drivers/platform/x86/intel_scu_ipc.c | 68 ----------------------------
> 2 files changed, 80 deletions(-)
>
> diff --git a/arch/x86/include/asm/intel_scu_ipc.h b/arch/x86/include/asm/intel_scu_ipc.h
> index b2dde96e0611..b59afa59a4cb 100644
> --- a/arch/x86/include/asm/intel_scu_ipc.h
> +++ b/arch/x86/include/asm/intel_scu_ipc.h
> @@ -22,24 +22,12 @@
> /* Read single register */
> int intel_scu_ipc_ioread8(u16 addr, u8 *data);
>
> -/* Read two sequential registers */
> -int intel_scu_ipc_ioread16(u16 addr, u16 *data);
> -
> -/* Read four sequential registers */
> -int intel_scu_ipc_ioread32(u16 addr, u32 *data);
> -
> /* Read a vector */
> int intel_scu_ipc_readv(u16 *addr, u8 *data, int len);
>
> /* Write single register */
> int intel_scu_ipc_iowrite8(u16 addr, u8 data);
>
> -/* Write two sequential registers */
> -int intel_scu_ipc_iowrite16(u16 addr, u16 data);
> -
> -/* Write four sequential registers */
> -int intel_scu_ipc_iowrite32(u16 addr, u32 data);
> -
> /* Write a vector */
> int intel_scu_ipc_writev(u16 *addr, u8 *data, int len);
>
> diff --git a/drivers/platform/x86/intel_scu_ipc.c b/drivers/platform/x86/intel_scu_ipc.c
> index 997fdac920c6..ba857e54800b 100644
> --- a/drivers/platform/x86/intel_scu_ipc.c
> +++ b/drivers/platform/x86/intel_scu_ipc.c
> @@ -237,40 +237,6 @@ int intel_scu_ipc_ioread8(u16 addr, u8 *data)
> }
> EXPORT_SYMBOL(intel_scu_ipc_ioread8);
>
> -/**
> - * intel_scu_ipc_ioread16 - read a word via the SCU
> - * @addr: register on SCU
> - * @data: return pointer for read word
> - *
> - * Read a register pair. Returns 0 on success or an error code. All
> - * locking between SCU accesses is handled for the caller.
> - *
> - * This function may sleep.
> - */
> -int intel_scu_ipc_ioread16(u16 addr, u16 *data)
> -{
> - u16 x[2] = {addr, addr + 1};
> - return pwr_reg_rdwr(x, (u8 *)data, 2, IPCMSG_PCNTRL, IPC_CMD_PCNTRL_R);
> -}
> -EXPORT_SYMBOL(intel_scu_ipc_ioread16);
> -
> -/**
> - * intel_scu_ipc_ioread32 - read a dword via the SCU
> - * @addr: register on SCU
> - * @data: return pointer for read dword
> - *
> - * Read four registers. Returns 0 on success or an error code. All
> - * locking between SCU accesses is handled for the caller.
> - *
> - * This function may sleep.
> - */
> -int intel_scu_ipc_ioread32(u16 addr, u32 *data)
> -{
> - u16 x[4] = {addr, addr + 1, addr + 2, addr + 3};
> - return pwr_reg_rdwr(x, (u8 *)data, 4, IPCMSG_PCNTRL, IPC_CMD_PCNTRL_R);
> -}
> -EXPORT_SYMBOL(intel_scu_ipc_ioread32);
> -
> /**
> * intel_scu_ipc_iowrite8 - write a byte via the SCU
> * @addr: register on SCU
> @@ -287,40 +253,6 @@ int intel_scu_ipc_iowrite8(u16 addr, u8 data)
> }
> EXPORT_SYMBOL(intel_scu_ipc_iowrite8);
>
> -/**
> - * intel_scu_ipc_iowrite16 - write a word via the SCU
> - * @addr: register on SCU
> - * @data: word to write
> - *
> - * Write two registers. Returns 0 on success or an error code. All
> - * locking between SCU accesses is handled for the caller.
> - *
> - * This function may sleep.
> - */
> -int intel_scu_ipc_iowrite16(u16 addr, u16 data)
> -{
> - u16 x[2] = {addr, addr + 1};
> - return pwr_reg_rdwr(x, (u8 *)&data, 2, IPCMSG_PCNTRL, IPC_CMD_PCNTRL_W);
> -}
> -EXPORT_SYMBOL(intel_scu_ipc_iowrite16);
> -
> -/**
> - * intel_scu_ipc_iowrite32 - write a dword via the SCU
> - * @addr: register on SCU
> - * @data: dword to write
> - *
> - * Write four registers. Returns 0 on success or an error code. All
> - * locking between SCU accesses is handled for the caller.
> - *
> - * This function may sleep.
> - */
> -int intel_scu_ipc_iowrite32(u16 addr, u32 data)
> -{
> - u16 x[4] = {addr, addr + 1, addr + 2, addr + 3};
> - return pwr_reg_rdwr(x, (u8 *)&data, 4, IPCMSG_PCNTRL, IPC_CMD_PCNTRL_W);
> -}
> -EXPORT_SYMBOL(intel_scu_ipc_iowrite32);
> -
> /**
> * intel_scu_ipc_readvv - read a set of registers
> * @addr: register list
> --
> 2.24.1
>

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2020-01-08 17:42    [W:0.247 / U:3.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site