lkml.org 
[lkml]   [2020]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [resend v1 1/5] block/genhd: Notify udev about capacity change
On Fri, Jan 03, 2020 at 06:16:39AM +0000, Chaitanya Kulkarni wrote:
> Since disk_set_capacity(() is on the same line as set_capacity()
> we should follow the same convention, which is :-
>
> 1. Avoid exporting symbol.
> 2. Mark new function in-line.
>
> Unless there is a very specific reason for breaking the pattern.

Why would we mark it as inline? It isn't by any means in the fast
path, and there are no easy opportunities for constant propagation,
so the only thing that would do is increase the code size.

\
 
 \ /
  Last update: 2020-01-08 16:03    [W:0.078 / U:1.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site