lkml.org 
[lkml]   [2020]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v10 2/2] watchdog: mtk_wdt: mt8183: Add reset controller
From
Date


On 08/01/2020 10:25, Nicolas Boichat wrote:
> On Mon, Jan 6, 2020 at 11:11 AM Jiaxin Yu <jiaxin.yu@mediatek.com> wrote:
>>
>> Add reset controller API in watchdog driver.
>> Besides watchdog, MTK toprgu module alsa provide sub-system (eg, audio,
>> camera, codec and connectivity) software reset functionality.
>
> You add support for reset controller on both 8183 and 2712, do you
> want to say that in the commit title and message?
>

I normally prefer to split that into at least two patches.

Regards,
Matthias

>>
>> Signed-off-by: yong.liang <yong.liang@mediatek.com>
>> Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
>> Reviewed-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
>> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
>> ---
>> drivers/watchdog/mtk_wdt.c | 105 ++++++++++++++++++++++++++++++++++++-
>> 1 file changed, 104 insertions(+), 1 deletion(-)

\
 
 \ /
  Last update: 2020-01-08 15:14    [W:0.040 / U:5.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site