lkml.org 
[lkml]   [2020]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] gianfar: Solve ethernet TX/RX problems for ls1021a
Date
Hi,

Fabio Estevam <festevam@gmail.com> 於 2020年1月7日 週二 下午10:17寫道:
>
> On Tue, Jan 7, 2020 at 11:13 AM Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > > diff --git a/drivers/net/ethernet/freescale/gianfar.c
> > > b/drivers/net/ethernet/freescale/gianfar.c
> > > index 72868a28b621..ab4e45199df9 100644
> > > --- a/drivers/net/ethernet/freescale/gianfar.c
> > > +++ b/drivers/net/ethernet/freescale/gianfar.c
> > > @@ -833,6 +833,7 @@ static int gfar_of_init(struct platform_device
> > > *ofdev, struct net_device **pdev)
> > >
> > > /* Find the TBI PHY. If it's not there, we don't support SGMII */
> > > priv->tbi_node = of_parse_phandle(np, "tbi-handle", 0);
> > > + priv->dma_endian_le = of_property_read_bool(np,
> > > + "fsl,dma-endian-le");
> >
> > Hi Johnson
> >
> > You need to document this new property in the binding.

Thanks yuor remind, I'll take care of it later
>
> Yes, but what about calling it 'little-endian' which is commonly used
> in arch/arm64/boot/dts/freescale/fsl-lsxxx device trees?
It sounds good, use "dma-endian-le" because it's from freescale's SDK for arm (32bit).

Thanks your suggestions!

Best regards,
Johnson
\
 
 \ /
  Last update: 2020-01-08 06:27    [W:0.044 / U:23.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site