lkml.org 
[lkml]   [2020]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] [net-next] [v2] socket: fix unused-function warning
From
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 8 Jan 2020 22:44:43 +0100

> When procfs is disabled, the fdinfo code causes a harmless
> warning:
>
> net/socket.c:1000:13: error: 'sock_show_fdinfo' defined but not used [-Werror=unused-function]
> static void sock_show_fdinfo(struct seq_file *m, struct file *f)
>
> Move the function definition up so we can use a single #ifdef
> around it.
>
> Fixes: b4653342b151 ("net: Allow to show socket-specific information in /proc/[pid]/fdinfo/[fd]")
> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> Acked-by: Kirill Tkhai <ktkhai@virtuozzo.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thanks Arnd.

\
 
 \ /
  Last update: 2020-01-09 00:03    [W:0.060 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site