lkml.org 
[lkml]   [2020]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] power: avs: qcom-cpr: Fix error code in cpr_fuse_corner_init()
On Wed, Jan 8, 2020 at 6:34 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> We're returning the wrong variable. "ret" isn't initialized.
>
> Fixes: bf6910abf548 ("power: avs: Add support for CPR (Core Power Reduction)")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/power/avs/qcom-cpr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c
> index 9247f53550b3..0321729431a5 100644
> --- a/drivers/power/avs/qcom-cpr.c
> +++ b/drivers/power/avs/qcom-cpr.c
> @@ -922,7 +922,7 @@ static int cpr_fuse_corner_init(struct cpr_drv *drv)
> uV = cpr_read_fuse_uV(desc, fdata, fuses->init_voltage,
> step_volt, drv);
> if (uV < 0)
> - return ret;
> + return uV;
>
> fuse->min_uV = fdata->min_uV;
> fuse->max_uV = fdata->max_uV;
> --

Thanks for the fix, but this issue has been fixed already.

\
 
 \ /
  Last update: 2020-01-08 23:29    [W:0.039 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site