Messages in this thread | | | Subject | Re: [PATCH v10 6/9] nvme: Export existing nvme core functions | From | Max Gurtovoy <> | Date | Wed, 8 Jan 2020 23:48:42 +0200 |
| |
On 1/8/2020 7:40 PM, Logan Gunthorpe wrote: > Export nvme_put_ns(), nvme_command_effects(), nvme_execute_passthru_rq() > and nvme_find_get_ns() for use in the nvmet passthru code. > > The exports are conditional on CONFIG_NVME_TARGET_PASSTHRU. > > Based-on-a-patch-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> > Signed-off-by: Logan Gunthorpe <logang@deltatee.com> > --- > drivers/nvme/host/core.c | 14 +++++++++----- > drivers/nvme/host/nvme.h | 5 +++++ > 2 files changed, 14 insertions(+), 5 deletions(-) > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index d7912e7a9911..037415882d46 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -463,7 +463,7 @@ static void nvme_free_ns(struct kref *kref) > kfree(ns); > } > > -static void nvme_put_ns(struct nvme_ns *ns) > +void nvme_put_ns(struct nvme_ns *ns) > { > kref_put(&ns->kref, nvme_free_ns); > } > @@ -896,8 +896,8 @@ static void *nvme_add_user_metadata(struct bio *bio, void __user *ubuf, > return ERR_PTR(ret); > } > > -static u32 nvme_command_effects(struct nvme_ctrl *ctrl, struct nvme_ns *ns, > - u8 opcode) > +u32 nvme_command_effects(struct nvme_ctrl *ctrl, struct nvme_ns *ns, > + u8 opcode) > { > u32 effects = 0; > > @@ -982,7 +982,7 @@ static void nvme_passthru_end(struct nvme_ctrl *ctrl, u32 effects) > nvme_queue_scan(ctrl); > } > > -static void nvme_execute_passthru_rq(struct request *rq) > +void nvme_execute_passthru_rq(struct request *rq) > { > struct nvme_command *cmd = nvme_req(rq)->cmd; > struct nvme_ctrl *ctrl = nvme_req(rq)->ctrl; > @@ -3441,7 +3441,7 @@ static int ns_cmp(void *priv, struct list_head *a, struct list_head *b) > return nsa->head->ns_id - nsb->head->ns_id; > } > > -static struct nvme_ns *nvme_find_get_ns(struct nvme_ctrl *ctrl, unsigned nsid) > +struct nvme_ns *nvme_find_get_ns(struct nvme_ctrl *ctrl, unsigned nsid) > { > struct nvme_ns *ns, *ret = NULL; > > @@ -4225,6 +4225,10 @@ EXPORT_SYMBOL_GPL(nvme_sync_queues); > * use by the nvmet-passthru and should not be used for > * other things. > */ > +EXPORT_SYMBOL_GPL(nvme_put_ns); > +EXPORT_SYMBOL_GPL(nvme_command_effects); > +EXPORT_SYMBOL_GPL(nvme_execute_passthru_rq); > +EXPORT_SYMBOL_GPL(nvme_find_get_ns);
Since this is the convention in the driver, can you export the symbols at the end of each function ?
Otherwise looks good,
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
> > struct nvme_ctrl *nvme_ctrl_get_by_path(const char *path) > { > diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h > index 356e4062796e..b1b1e7dd866b 100644 > --- a/drivers/nvme/host/nvme.h > +++ b/drivers/nvme/host/nvme.h > @@ -687,6 +687,11 @@ static inline void nvme_hwmon_init(struct nvme_ctrl *ctrl) { } > * use by the nvmet-passthru and should not be used for > * other things. > */ > +void nvme_put_ns(struct nvme_ns *ns); > +u32 nvme_command_effects(struct nvme_ctrl *ctrl, struct nvme_ns *ns, > + u8 opcode); > +void nvme_execute_passthru_rq(struct request *rq); > +struct nvme_ns *nvme_find_get_ns(struct nvme_ctrl *ctrl, unsigned int nsid); > struct nvme_ctrl *nvme_ctrl_get_by_path(const char *path); > #endif /* CONFIG_NVME_TARGET_PASSTHRU */ >
| |