lkml.org 
[lkml]   [2020]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/2] drm/radeon: change call sites to handle return value properly.
Date
Ideally, the failure of set_memory_*() should be passed up the call stack,
and callers should examine the failure and deal with it. Fix those call
sites in drm/radeon to handle retval properly.
Since fini functions are always void, print errors for the failures.

Signed-off-by: Tianlin Li <tli@digitalocean.com>
---
drivers/gpu/drm/radeon/r100.c | 3 ++-
drivers/gpu/drm/radeon/rs400.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c
index 110fb38004b1..7eafe15ba124 100644
--- a/drivers/gpu/drm/radeon/r100.c
+++ b/drivers/gpu/drm/radeon/r100.c
@@ -706,7 +706,8 @@ void r100_pci_gart_fini(struct radeon_device *rdev)
{
radeon_gart_fini(rdev);
r100_pci_gart_disable(rdev);
- radeon_gart_table_ram_free(rdev);
+ if (radeon_gart_table_ram_free(rdev))
+ DRM_ERROR("radeon: failed free system ram for GART page table.\n");
}

int r100_irq_set(struct radeon_device *rdev)
diff --git a/drivers/gpu/drm/radeon/rs400.c b/drivers/gpu/drm/radeon/rs400.c
index 117f60af1ee4..de3674f5fe23 100644
--- a/drivers/gpu/drm/radeon/rs400.c
+++ b/drivers/gpu/drm/radeon/rs400.c
@@ -210,7 +210,8 @@ void rs400_gart_fini(struct radeon_device *rdev)
{
radeon_gart_fini(rdev);
rs400_gart_disable(rdev);
- radeon_gart_table_ram_free(rdev);
+ if (radeon_gart_table_ram_free(rdev))
+ DRM_ERROR("radeon: failed free system ram for GART page table.\n");
}

#define RS400_PTE_UNSNOOPED (1 << 0)
--
2.17.1
\
 
 \ /
  Last update: 2020-01-07 20:27    [W:0.073 / U:13.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site