Messages in this thread | | | Subject | Re: [PATCH v2] hwmon: Driver for temperature sensors on SATA drives | From | Guenter Roeck <> | Date | Tue, 7 Jan 2020 05:00:39 -0800 |
| |
On 1/6/20 8:10 PM, Martin K. Petersen wrote: > > Hi Guenter! > >>> - I still think sensor naming needs work. How and where are the >>> "drivetemp-scsi-8-140" names generated? >>> >> Quick one: In libsensors, outside the kernel. The naming is generic, >> along the line of <driver name>-<bus name>-<bus index>-<slot>. > > I understand that there are sensors that may not have an obvious > associated topology and therefore necessitate coming up with a suitable > naming or enumeration scheme. But in this case we already have a > well-defined SCSI device name. Any particular reason you don't shift the > chip.addr back and print the H:C:T:L format that you used as input? > > However arcane H:C:T:L may seem, I think that predictable naming would > make things a lot easier for users that need to identify which device > matches which sensor... >
Not sure I understand. Do you mean to add "H:C:T:L" to "drivetemp" ? That would make it something like "drivetemp:H:C:T:L-scsi-8-140". Not sure if that is really useful, and it would at least be partially redundant.
"scsi-8-140" is created by libsensors, so any change in that would have to be made there, not in the kernel driver.
Guenter
| |