lkml.org 
[lkml]   [2020]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: [PATCH 05/13] mailbox: bcm2835: convert to devm_platform_ioremap_resource
    From
    Date
    On Sat, 2019-12-28 at 18:35 +0000, Yangtao Li wrote:
    > Use devm_platform_ioremap_resource() to simplify code.
    >
    > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
    > ---

    Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>

    Thanks!

    > drivers/mailbox/bcm2835-mailbox.c | 4 +---
    > 1 file changed, 1 insertion(+), 3 deletions(-)
    >
    > diff --git a/drivers/mailbox/bcm2835-mailbox.c b/drivers/mailbox/bcm2835-
    > mailbox.c
    > index 39761d190545..79f93c9c7682 100644
    > --- a/drivers/mailbox/bcm2835-mailbox.c
    > +++ b/drivers/mailbox/bcm2835-mailbox.c
    > @@ -137,7 +137,6 @@ static int bcm2835_mbox_probe(struct platform_device
    > *pdev)
    > {
    > struct device *dev = &pdev->dev;
    > int ret = 0;
    > - struct resource *iomem;
    > struct bcm2835_mbox *mbox;
    >
    > mbox = devm_kzalloc(dev, sizeof(*mbox), GFP_KERNEL);
    > @@ -153,8 +152,7 @@ static int bcm2835_mbox_probe(struct platform_device
    > *pdev)
    > return -ENODEV;
    > }
    >
    > - iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    > - mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
    > + mbox->regs = devm_platform_ioremap_resource(pdev, 0);
    > if (IS_ERR(mbox->regs)) {
    > ret = PTR_ERR(mbox->regs);
    > dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2020-01-07 11:58    [W:4.111 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site