lkml.org 
[lkml]   [2020]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Cocci] [PATCH] coccinnelle: Remove ptr_ret script
On Tue, Jan 07, 2020 at 11:06:56AM +0100, Julia Lawall wrote:
>
>
> On Tue, 7 Jan 2020, Maxime Ripard wrote:
>
> > The ptr_ret script script addresses a number of situations where we end up
> > testing an error pointer, and if it's an error returning it, or return 0
> > otherwise to transform it into a PTR_ERR_OR_ZERO call.
> >
> > So it will convert a block like this:
> >
> > if (IS_ERR(err))
> > return PTR_ERR(err);
> >
> > return 0;
> >
> > into
> >
> > return PTR_ERR_OR_ZERO(err);
> >
> > While this is technically correct, it has a number of drawbacks. First, it
> > merges the error and success path, which will make it harder for a reviewer
> > or reader to grasp.
> >
> > It's also more difficult to extend if we were to add some code between the
> > error check and the function return, making the author essentially revert
> > that patch before adding new lines, while it would have been a trivial
> > addition otherwise for the rewiever.
> >
> > Therefore, since that script is only about cosmetic in the first place,
> > let's remove it since it's not worth it.
> >
> > Cc: Jani Nikula <jani.nikula@linux.intel.com>
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > Cc: Mark Brown <broonie@kernel.org>
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>
> Acked-by: Julia Lawall <julia.lawall@inria.fr>

Convincing patch description, good catch!

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-01-07 11:30    [W:0.097 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site